Re: Improve the connection failure error messages

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>
Cc: Peter Smith <smithpb2250(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Improve the connection failure error messages
Date: 2024-04-26 07:40:27
Message-ID: 76155D82-5B97-41B1-B373-8BC6194AE522@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 22 Mar 2024, at 11:42, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> wrote:

> Here is the v4 patch with changes required in slotfuncs.c and slotsync.c files.

- errmsg("could not connect to the primary server: %s", err));
+ errmsg("\"%s\" could not connect to the primary server: %s", app_name.data, err));

Messages like this should perhaps have translator comments to indicate what the
leading "%s" will contain?

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Zhijie Hou (Fujitsu) 2024-04-26 07:52:51 RE: Improving the latch handling between logical replication launcher and worker processes.
Previous Message Frédéric Yhuel 2024-04-26 07:35:24 Re: New GUC autovacuum_max_threshold ?