Re: removal of md5 from example code

From: Jon Wolski <jonwolski(at)gmail(dot)com>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: pgsql-docs(at)lists(dot)postgresql(dot)org
Subject: Re: removal of md5 from example code
Date: 2018-02-02 01:23:31
Message-ID: CABZG8z866RH733UWbKA-oD5J4XE0kQc-LfBrDV+fF=4U=bAsgw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs

I think I get it, now.

Is the reason for including the `pass` in the example so that the
documentation can demonstrate `citext` along side case-sensitive text?

If so, I struggle to come up with anything more obvious than a password
hash for a case where case-sensitive comparison of text is necessary. The
only other thing that comes to mind is an external system identifier like a
Salesforce object id of a user. That would not be as universally obvious an
example of case-sensitivity to all PostgreSQL users..

On Tue, Jan 30, 2018 at 10:02 PM, Peter Eisentraut <
peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:

> On 1/17/18 11:14, PG Doc comments form wrote:
> > The documentation at
> > https://www.postgresql.org/docs/current/static/citext.html shows an
> example
> > using md5 for password hashes. This is generally a bad practice and not
> > relevant to the feature documented.
> >
> > I recommend removing the password column from this example or replacing
> the
> > md5 hash with something more secure (a secure hash algorithm with a
> salt).
>
> We don't have any other hash functions built in and exposed at the SQL
> level. (Maybe that is a problem.) Do you have any other ideas how to
> rewrite that example?
>
> --
> Peter Eisentraut http://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>

In response to

Browse pgsql-docs by date

  From Date Subject
Next Message PG Doc comments form 2018-02-02 15:19:14 estudent
Previous Message Daniel Gustafsson 2018-02-01 13:03:09 Re: A simple question