Re: Improve base backup protocol documentation

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Improve base backup protocol documentation
Date: 2019-09-03 07:50:44
Message-ID: CABUevEzxzxiEYUfiBP6h2ym6DzhOofi7_AcqjsXDE4Ee0gqcYw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Aug 28, 2019 at 4:58 PM Peter Eisentraut <
peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:

> It was apparently entirely undocumented that the tablespace size
> estimates sent by the base backup protocol are in kilobytes. Here is a
> patch to document that. Also, a related clarification in the
> pg_basebackup.c source code: It was not clear without analyzing the
> whole stack that "totalsize" is in kilobytes and "totaldone" is in bytes.
>
>
+1, these both look like reasonable changes to me.

//Magnus

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2019-09-03 08:44:17 Const version of castNode()
Previous Message Peter Eisentraut 2019-09-03 07:24:14 Re: Unix-domain socket support on Windows