| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Improve base backup protocol documentation |
| Date: | 2019-09-03 10:03:25 |
| Message-ID: | 37d3acf9-256d-44b3-6124-e82132739973@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-09-03 09:50, Magnus Hagander wrote:
> On Wed, Aug 28, 2019 at 4:58 PM Peter Eisentraut
> <peter(dot)eisentraut(at)2ndquadrant(dot)com
> <mailto:peter(dot)eisentraut(at)2ndquadrant(dot)com>> wrote:
>
> It was apparently entirely undocumented that the tablespace size
> estimates sent by the base backup protocol are in kilobytes. Here is a
> patch to document that. Also, a related clarification in the
> pg_basebackup.c source code: It was not clear without analyzing the
> whole stack that "totalsize" is in kilobytes and "totaldone" is in
> bytes.
>
>
> +1, these both look like reasonable changes to me.
committed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2019-09-03 10:03:26 | Re: BUG #15977: Inconsistent behavior in chained transactions |
| Previous Message | Peter Eisentraut | 2019-09-03 09:54:57 | Re: BUG #15977: Inconsistent behavior in chained transactions |