Re: Git repo problem?

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>, PostgreSQL WWW <pgsql-www(at)lists(dot)postgresql(dot)org>
Subject: Re: Git repo problem?
Date: 2019-06-14 16:42:19
Message-ID: CABUevEzaBqp6YUbeP6SRL2hxW7BgMG3n1ZMp1cbBjEJVR161Gg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-www

On Fri, Jun 14, 2019 at 4:51 PM Stephen Frost <sfrost(at)snowman(dot)net> wrote:

> * Magnus Hagander (magnus(at)hagander(dot)net) wrote:
> > Nice spot. I think you have at least found the issue, but I think it may
> > not be the best fix. Given that when we decode the string we do it with
> > errors=ignore, we might loose data. Does the attached patch fix it in
> your
> > tests as well? Instead of encoding/recoding, it just sticks the old line
> > back on the list (which also matches the comment).
>
> Tested and yes, this patch fixes it, and I agree that it makes more
> sense than the approach I was using.
>
> Would be great to get it deployed soon. :)
>

Nah, now that we know what it was, we should let it cook for a while.

.....

I guess that's long enough. Deployed.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

In response to

Browse pgsql-www by date

  From Date Subject
Next Message Daniel Gustafsson 2019-06-17 11:31:21 Re: Install github app to automatically close PRs on github mirror
Previous Message Stephen Frost 2019-06-14 14:51:30 Re: Git repo problem?