| From: | Stephen Frost <sfrost(at)snowman(dot)net> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>, PostgreSQL WWW <pgsql-www(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Git repo problem? |
| Date: | 2019-06-14 14:51:30 |
| Message-ID: | 20190614145130.GC2480@tamriel.snowman.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-www |
Greetings,
* Magnus Hagander (magnus(at)hagander(dot)net) wrote:
> Nice spot. I think you have at least found the issue, but I think it may
> not be the best fix. Given that when we decode the string we do it with
> errors=ignore, we might loose data. Does the attached patch fix it in your
> tests as well? Instead of encoding/recoding, it just sticks the old line
> back on the list (which also matches the comment).
Tested and yes, this patch fixes it, and I agree that it makes more
sense than the approach I was using.
Would be great to get it deployed soon. :)
Thanks!
Stephen
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2019-06-14 16:42:19 | Re: Git repo problem? |
| Previous Message | Magnus Hagander | 2019-06-14 09:35:02 | Re: Git repo problem? |