Re: BUG #16896: pg_standby: Missing reference when building on Windows

On Thu, Feb 25, 2021 at 9:17 AM PG Bug reporting form
<noreply(at)postgresql(dot)org> wrote:
>
> The following bug has been logged on the website:
>
> Bug reference: 16896
> Logged by: RobiOne (Robert Grange)
> Email address: robionekenobi(at)bluewin(dot)ch
> PostgreSQL version: 13.2
> Operating system: Windows 10
> Description:
>
> Hi,
>
> after building on windows (cleant.bat then build.bat Debug', the pg_standby
> project is missing references to libpgport and libpgcommon
>
> The error is probalby in src/tools/msvc/Mkvcbuild.pm, as the lines
>
> my @contrib_uselibpgport = ('oid2name', 'vacuumlo');
> my @contrib_uselibpgcommon = ('oid2name', 'vacuumlo');
>
> must be
>
> my @contrib_uselibpgport = ('oid2name', 'pg_standby', 'vacuumlo');
> my @contrib_uselibpgcommon = ('oid2name', 'pg_standby', 'vacuumlo');
>
> After having added this locally, all worked fine

This sounds like you may have an unclean checkout with a mix of
version 13 and HEAD in it.

In version 13, pg_standby is already in those lines, and has been for
years. It has, however, been removed in HEAD back in January, along
with all of pg_standby. So if building HEAD then adding those back
should be failing. It looks like you have the src/tools/msvc directory
from HEAD and src/contrib from 13.

So you'll want to investigate why and make sure you have a completely
clean checkout.

--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/