Re: Deselecting "Receive Mail" on the website ml subscribe form is broken

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Amir Rohan <amir(dot)rohan(at)mail(dot)com>, PostgreSQL WWW <pgsql-www(at)postgresql(dot)org>
Subject: Re: Deselecting "Receive Mail" on the website ml subscribe form is broken
Date: 2015-10-02 09:00:18
Message-ID: CABUevEzNgvBNDRcuJUML+AQGsLL-HGidSs44Y5bMRQU-DU+Q6A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-www

On Tue, Sep 29, 2015 at 4:14 PM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
wrote:

> Magnus Hagander wrote:
> > On Mon, Sep 28, 2015 at 12:07 AM, Amir Rohan <amir(dot)rohan(at)mail(dot)com>
> wrote:
> >
> > > >>>>> subscribe pgsql-bugs
> > > >---- The subscribe command did not succeed.
> > > >----
> > > >---- Your request to subscribe must be confirmed.
> > > >---- Confirmation instructions have been sent in an e-mail message to
> > > ----
> > > >>>> set nomail
> > > **** The "nomail" mailing list is not supported at
> > > **** PostgreSQL Mailing Lists.
>
> > I wonder if this has ever worked. Alvaro, do you know if something has
> > changed there? ISTM that we pass on a "set digest" and a "set nomail"
> > directly after the subscribe command -- does that work at all, since the
> > subscription hasn't been confirmed yet?
>
> I was looking at this when Amir first posted it, and I was wondering how
> it was possible that it ever worked in the first place. The second
> command should really be "set pgsql-bugs nomail" (patch below), but as
> you say I'm unsure that it works if the subscription hasn't been
> confirmed. A command that should work in either case is
> subscribe-set pgsql-bugs nomail
> subscribe-set pgsql-bugs nomail,digest
> but I'm not sure what's the python-ish way to express that.
>

Well, if we're going to do it, let's do it right :)

Does the attached logic seem right?

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

Attachment Content-Type Size
subscribe_commands.patch text/x-patch 1.2 KB

In response to

Responses

Browse pgsql-www by date

  From Date Subject
Next Message Stephen Frost 2015-10-02 12:45:50 Re: No easy way to join discussion in existing thread when not subscribed
Previous Message Amir Rohan 2015-10-02 03:56:07 Re: No easy way to join discussion in existing thread when not subscribed