Re: Deselecting "Receive Mail" on the website ml subscribe form is broken

Magnus Hagander wrote:
> On Mon, Sep 28, 2015 at 12:07 AM, Amir Rohan <amir(dot)rohan(at)mail(dot)com> wrote:
>
> > >>>>> subscribe pgsql-bugs
> > >---- The subscribe command did not succeed.
> > >----
> > >---- Your request to subscribe must be confirmed.
> > >---- Confirmation instructions have been sent in an e-mail message to
> > ----
> > >>>> set nomail
> > **** The "nomail" mailing list is not supported at
> > **** PostgreSQL Mailing Lists.

> I wonder if this has ever worked. Alvaro, do you know if something has
> changed there? ISTM that we pass on a "set digest" and a "set nomail"
> directly after the subscribe command -- does that work at all, since the
> subscription hasn't been confirmed yet?

I was looking at this when Amir first posted it, and I was wondering how
it was possible that it ever worked in the first place. The second
command should really be "set pgsql-bugs nomail" (patch below), but as
you say I'm unsure that it works if the subscription hasn't been
confirmed. A command that should work in either case is
subscribe-set pgsql-bugs nomail
subscribe-set pgsql-bugs nomail,digest
but I'm not sure what's the python-ish way to express that.

diff --git a/pgweb/lists/views.py b/pgweb/lists/views.py
index bb8b445..906735b 100644
--- a/pgweb/lists/views.py
+++ b/pgweb/lists/views.py
@@ -21,9 +21,9 @@ def subscribe(request):
mailtxt += "subscribe %s\n" % form.cleaned_data['lists']
mailsubject = "subscribe"
if not form.cleaned_data['receive']:
- mailtxt += "set nomail\n"
+ mailtxt += "set %s nomail\n" % form.cleaned_data['lists']
if form.cleaned_data['digest']:
- mailtxt += "set digest\n"
+ mailtxt += "set %s digest\n" % form.cleaned_data['lists']
else:
mailtxt += "unsubscribe %s\n" % form.cleaned_data['lists']
mailsubject = "unsubscribe"

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services