From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: "unexpected EOF" messages |
Date: | 2012-05-03 19:26:57 |
Message-ID: | CABUevEzCAywLg0otSOR85S7UKd_6=GQEEzrm0SVkYmBCNT-z7g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, May 3, 2012 at 7:48 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> Heh - we already used ERRCODE_CONNECTION_FAILURE on the errors in
>> copy.c. Since COPY can only happen when there is a transaction
>> (right?), I just changed those error messages for consistency.
>
> Agreed on changing the message texts to match, but I wonder whether
> we ought not switch all those SQLSTATEs to something different. Per my
> comment to Kevin, I think the whole 08 class is meant to be issued on
> the client side. Maybe it's okay to conflate a server-detected
> connection loss with client-detected loss, but I'm not convinced.
Sure,that's a simple search and replace of course... If we can come to
a decision about what codes to actually use. I'm not sure I have much
input other than that I agree they need to be different :-)
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Kevin Grittner | 2012-05-03 19:31:22 | Re: Re: xReader, double-effort (was: Temporary tables under hot standby) |
Previous Message | Simon Riggs | 2012-05-03 19:20:45 | Re: CLOG extension |