| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: "unexpected EOF" messages |
| Date: | 2012-05-03 17:48:13 |
| Message-ID: | 8839.1336067293@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Magnus Hagander <magnus(at)hagander(dot)net> writes:
> Heh - we already used ERRCODE_CONNECTION_FAILURE on the errors in
> copy.c. Since COPY can only happen when there is a transaction
> (right?), I just changed those error messages for consistency.
Agreed on changing the message texts to match, but I wonder whether
we ought not switch all those SQLSTATEs to something different. Per my
comment to Kevin, I think the whole 08 class is meant to be issued on
the client side. Maybe it's okay to conflate a server-detected
connection loss with client-detected loss, but I'm not convinced.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2012-05-03 18:19:42 | Re: Advisory locks seem rather broken |
| Previous Message | Kevin Grittner | 2012-05-03 17:44:05 | Re: "unexpected EOF" messages |