Re: Make pg_basebackup -x stream the default

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Vladimir Rusinov <vrusinov(at)google(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Make pg_basebackup -x stream the default
Date: 2017-01-09 15:05:10
Message-ID: CABUevEz-uSWGs1gcbeQR_XgtF-D1GfaAhk6OOeOybzEhi_+2iQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jan 7, 2017 at 1:32 PM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
wrote:

> On Sat, Jan 7, 2017 at 12:04 AM, Magnus Hagander <magnus(at)hagander(dot)net>
> wrote:
> > On Wed, Jan 4, 2017 at 10:43 AM, Magnus Hagander <magnus(at)hagander(dot)net>
> > wrote:
> >> Meh, just as I was going to respond "committed" I noticed this second
> >> round of review comments. Apologies, pushed without that.
> >>
> >> I agree on the change with includewal/streamwal. That was already the
> case
> >> in the existing code of course, but that doesn't mean it couldn't be
> made
> >> better. I'll take a look at doing that as a separate patch.
> >>
> >
> > Here's a patch that does this. Does this match what you were thinking?
>
> Yes, that's it. I have looked at the patch in details and that looks
> correct to me.
>

OK. Pushed. I agree it made it more readable, if nothing else.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-01-09 15:17:20 Re: Increase pltcl test coverage
Previous Message Anastasia Lubennikova 2017-01-09 15:02:54 Re: WIP: Covering + unique indexes.