| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Vladimir Rusinov <vrusinov(at)google(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Make pg_basebackup -x stream the default |
| Date: | 2017-01-07 12:32:53 |
| Message-ID: | CAB7nPqR_d+1p-8c+HMLJZNi-e=_XYBr1MF9OyT_Wuffj5JjFEg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jan 7, 2017 at 12:04 AM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> On Wed, Jan 4, 2017 at 10:43 AM, Magnus Hagander <magnus(at)hagander(dot)net>
> wrote:
>> Meh, just as I was going to respond "committed" I noticed this second
>> round of review comments. Apologies, pushed without that.
>>
>> I agree on the change with includewal/streamwal. That was already the case
>> in the existing code of course, but that doesn't mean it couldn't be made
>> better. I'll take a look at doing that as a separate patch.
>>
>
> Here's a patch that does this. Does this match what you were thinking?
Yes, that's it. I have looked at the patch in details and that looks
correct to me.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Stark | 2017-01-07 13:25:08 | Re: pg_stat_activity.waiting_start |
| Previous Message | Pavel Stehule | 2017-01-07 11:39:39 | Re: merging some features from plpgsql2 project |