Re: pgsql: Kill pg_basebackup background process when exiting

On Wed, Feb 12, 2014 at 7:47 PM, Andres Freund <andres(at)2ndquadrant(dot)com>wrote:

>
> On 2014-02-12 17:46:48 +0000, Magnus Hagander wrote:
> > Kill pg_basebackup background process when exiting
> >
> > If an error occurs in the foreground (backup) process of pg_basebackup,
> > and we exit in a controlled way, the background process (streaming
> > xlog process) would stay around and keep streaming.
>
> It seems you need to add another include...
>
>
> http://pgbuildfarm.org/cgi-bin/show_log.pl?nm=nightjar&dt=2014-02-12%2018%3A37%3A37
>
> /pgbuild/root/HEAD/pgsql.39771/../pgsql/src/bin/pg_basebackup/pg_basebackup.c:
> In function 'disconnect_and_exit':
> /pgbuild/root/HEAD/pgsql.39771/../pgsql/src/bin/pg_basebackup/pg_basebackup.c:105:
> warning: implicit declaration of function 'kill'
> /pgbuild/root/HEAD/pgsql.39771/../pgsql/src/bin/pg_basebackup/pg_basebackup.c:105:
> error: 'SIGTERM' undeclared (first use in this function)
> /pgbuild/root/HEAD/pgsql.39771/../pgsql/src/bin/pg_basebackup/pg_basebackup.c:105:
> error: (Each undeclared identifier is reported only once
> /pgbuild/root/HEAD/pgsql.39771/../pgsql/src/bin/pg_basebackup/pg_basebackup.c:105:
> error: for each function it appears in.)
>
>
Interesting, that worked on my test platforms. That said - thanks for
pointing it out, will fix.

> that's
> #include <sys/types.h>
> #include <signal.h>
>

sys/types.h was already included. That's probably why it worked on my
linux. I'll add signal.h.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/