Re: pgsql: Kill pg_basebackup background process when exiting

Hi Magnus,

On 2014-02-12 17:46:48 +0000, Magnus Hagander wrote:
> Kill pg_basebackup background process when exiting
>
> If an error occurs in the foreground (backup) process of pg_basebackup,
> and we exit in a controlled way, the background process (streaming
> xlog process) would stay around and keep streaming.

It seems you need to add another include...

http://pgbuildfarm.org/cgi-bin/show_log.pl?nm=nightjar&dt=2014-02-12%2018%3A37%3A37

/pgbuild/root/HEAD/pgsql.39771/../pgsql/src/bin/pg_basebackup/pg_basebackup.c: In function 'disconnect_and_exit':
/pgbuild/root/HEAD/pgsql.39771/../pgsql/src/bin/pg_basebackup/pg_basebackup.c:105: warning: implicit declaration of function 'kill'
/pgbuild/root/HEAD/pgsql.39771/../pgsql/src/bin/pg_basebackup/pg_basebackup.c:105: error: 'SIGTERM' undeclared (first use in this function)
/pgbuild/root/HEAD/pgsql.39771/../pgsql/src/bin/pg_basebackup/pg_basebackup.c:105: error: (Each undeclared identifier is reported only once
/pgbuild/root/HEAD/pgsql.39771/../pgsql/src/bin/pg_basebackup/pg_basebackup.c:105: error: for each function it appears in.)

that's
#include <sys/types.h>
#include <signal.h>

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services