From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Show sequences owned by |
Date: | 2011-11-04 14:24:46 |
Message-ID: | CABUevEyHnFqYQZcT-6jV_-SCJrxLjNC4w3YhA533b9wM3iZ-Ow@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Nov 4, 2011 at 15:19, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> The attached patch makes the \d output for psql on a sequence show
>> which table/column owns the sequence. The table already showed the
>> dependency the other way through the default value, but going from
>> sequence back to table was not possible.
>
>> Comments/reviews?
>
> The join conditions are far from adequate. You can *not* just check the
> objid, you *must* check classid (and refclassid) to avoid being fooled
Uh, it does check classid. Or are you saying it's checked the wrong way?
But it's not checking refclassid, that's true - and should be fixed.
> by duplicate OIDs in different system catalogs. You've also not held
> to psql's normal conventions about fully qualifying names to avoid
> making assumptions about the search_path.
Will fix.
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Yoann Moreau | 2011-11-04 14:26:01 | Re: Term positions in GIN fulltext index |
Previous Message | Tom Lane | 2011-11-04 14:23:04 | Re: Show statistics target in \d+ |