Re: Show sequences owned by

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Show sequences owned by
Date: 2011-11-04 14:40:16
Message-ID: 7259.1320417616@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Magnus Hagander <magnus(at)hagander(dot)net> writes:
> On Fri, Nov 4, 2011 at 15:19, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> The join conditions are far from adequate. You can *not* just check the
>> objid, you *must* check classid (and refclassid) to avoid being fooled

> Uh, it does check classid. Or are you saying it's checked the wrong way?

Oh, sheesh, not enough caffeine. I was expecting to see it written as
part of the ON condition --- I always think of objid and classid as
being two parts of the join key for pg_depend queries. You should write
it as classid='pg_catalog.pg_class'::pg_catalog.regclass, but at least
it's there.

> But it's not checking refclassid, that's true - and should be fixed.

Yeah.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2011-11-04 14:41:53 Re: warning in pg_upgrade
Previous Message Magnus Hagander 2011-11-04 14:37:50 Re: Show sequences owned by