Re: invalid data in file backup_label problem on windows

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: David Steele <david(at)pgmasters(dot)net>, "wangsh(dot)fnst(at)fujitsu(dot)com" <wangsh(dot)fnst(at)fujitsu(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: invalid data in file backup_label problem on windows
Date: 2021-03-26 17:20:34
Message-ID: CABUevEwy1-9tH0FUa_C6+ffaBu+wwAsdjRh45v_kJP-=OPYd1g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Mar 26, 2021 at 5:52 PM Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
>
> On 3/26/21 10:19 AM, David Steele wrote:
> >
> >> No, the problem is you are using copy/paste and in doing so you are
> >> *changing'* the value that is being returned. You'll either need to
> >> update your copy/paste procedure to not mess with the newlines, or to
> >> use a better way to get the data out.
> >>
> >> If we need to clarify that in the documentation, I'm fine with that.
> >> Maybe add an extra sentence to the part about not modifying the output
> >> to mention that this includes changing newslines and also encoding
> >> (which would also break it, if you managed to find a non-ascii
> >> compatible encoding). Maybe even something along the line of "the
> >> contents have to be written in binary mode"?
> >
> > Perhaps something like the attached?
> >
> >
>
>
> That seems a bit opaque. Let's tell them exactly what they need to avoid.

Yeah, it seems a bit imprecise. Maybe something like "which includes
things like opening the file in binary mode"? (I want the "includes"
part because it also means other things, this is not the only thing).

--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Verite 2021-03-26 17:51:33 Re: Calendar support in localization
Previous Message Andres Freund 2021-03-26 17:16:40 Re: Walsender may fail to send wal to the end.