| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Walsender may fail to send wal to the end. |
| Date: | 2021-03-26 17:16:40 |
| Message-ID: | 20210326171640.i2nfqlslnpvckxxc@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2021-03-26 18:20:14 +0900, Kyotaro Horiguchi wrote:
> This is because XLogSendPhysical detects removal of the wal segment
> currently reading by shutdown checkpoint. However, there' no fear of
> overwriting of WAL segments at the time.
>
> So I think we can omit the call to CheckXLogRemoved() while
> MyWalSnd->state is WALSNDSTTE_STOPPING because the state comes after
> the shutdown checkpoint completes.
>
> Of course that doesn't help if walsender was running two segments
> behind. There still could be a small window for the failure. But it's
> a great help to save the case of just 1 segment behind.
-1. This seems like a bandaid to make a broken configuration work a tiny
bit better, without actually being meaningfully better.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2021-03-26 17:20:34 | Re: invalid data in file backup_label problem on windows |
| Previous Message | Andres Freund | 2021-03-26 17:14:36 | Re: make the stats collector shutdown without writing the statsfiles if the immediate shutdown is requested. |