Re: pgsql: Fix union for pgstat message types

On Sat, May 4, 2019 at 5:54 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> writes:
> > On Wed, May 01, 2019 at 10:34:52AM +0000, Magnus Hagander wrote:
> >> Fix union for pgstat message types
>
> > Should the tempfile bit be backported? That message was added in 9.2.
>
> It's just cosmetic I think. The main point of having everything in
> the union is to make sure the union's size/alignment are sufficient,
> but the tempfile message isn't anywhere near creating an issue there.
>

That was my thought as well. It's really only needed when we add new
things, to make sure we don't make those mistakes again. And nobody should
be adding new pgstat messages in old branches.

--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>