| From: | Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Aleksander Alekseev <aleksander(at)timescale(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Marco Slot <marco(dot)slot(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Christoph Berg <myon(at)debian(dot)org> |
| Subject: | Re: Potential ABI breakage in upcoming minor releases |
| Date: | 2024-11-15 18:40:06 |
| Message-ID: | CABOikdOQK4=xCLRE5a41=brZi-RJw=scnSq4JN3RjqL9x31k6A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Nov 15, 2024 at 11:39 PM Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>
wrote:
>
> Looking more carefully at the usage of `ResultRelInfo` in the PGD code, I
> think we might also be impacted by it. At one place, we loop through the
> `es_result_relations` array and a size mismatch there will cause problems.
> Interestingly, in v14 and above, we read from `es_opened_result_relations`,
> which is a List, so it should be safe. I will try some tests on v13 to see
> if they result in crashes. But it seems quite likely by reading the code.
>
>
Ah, the addition of a member to `ResultRelInfo` did not happen in v12 and
v13, even though the commit was backpatched all the way to v12. Maybe we
(PGD) got twice lucky :-) There could be other extensions which might be
looping through `es_result_relations` though and get impacted.
Thanks,
Pavan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shlok Kyal | 2024-11-15 18:40:45 | Re: Disallow UPDATE/DELETE on table with unpublished generated column as REPLICA IDENTITY |
| Previous Message | Noah Misch | 2024-11-15 18:35:29 | Re: Potential ABI breakage in upcoming minor releases |