| From: | Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Aleksander Alekseev <aleksander(at)timescale(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Marco Slot <marco(dot)slot(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Christoph Berg <myon(at)debian(dot)org> |
| Subject: | Re: Potential ABI breakage in upcoming minor releases |
| Date: | 2024-11-15 18:09:24 |
| Message-ID: | CABOikdMOAu6666_xWCPOfCxg4NzHE9tU-WVSpw3rbzUmDyW9fA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Nov 15, 2024 at 11:22 PM Noah Misch <noah(at)leadboat(dot)com> wrote:
>
>
> > I'm starting to lean to the opinion that we need a re-wrap.
>
> Perhaps. Even if we do rewrap for some reason, it's not a given that
> restoring the old struct size is net beneficial. If we restore the old
> struct
> size in v16.6, those who rebuild for v16.5 would need to rebuild again.
> Hearing about other ResultRelInfo arrays will help clarify that decision.
>
Looking more carefully at the usage of `ResultRelInfo` in the PGD code, I
think we might also be impacted by it. At one place, we loop through the
`es_result_relations` array and a size mismatch there will cause problems.
Interestingly, in v14 and above, we read from `es_opened_result_relations`,
which is a List, so it should be safe. I will try some tests on v13 to see
if they result in crashes. But it seems quite likely by reading the code.
Thanks,
Pavan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2024-11-15 18:21:05 | Re: logical replication: restart_lsn can go backwards (and more), seems broken since 9.4 |
| Previous Message | Masahiko Sawada | 2024-11-15 18:01:45 | Re: Skip collecting decoded changes of already-aborted transactions |