Re: PATCH: Exclude unlogged tables from base backups

From: Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>
To: David Steele <david(at)pgmasters(dot)net>
Cc: Teodor Sigaev <teodor(at)sigaev(dot)ru>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Adam Brightwell <adam(dot)brightwell(at)crunchydata(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Exclude unlogged tables from base backups
Date: 2018-03-26 07:52:57
Message-ID: CABOikdMb3HyX4u-4xr8O1Jfyb4fzOSLWA60DqLwR0o1k7FCA1Q@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Mar 26, 2018 at 1:03 PM, Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>
wrote:

> On Fri, Mar 23, 2018 at 9:51 PM, David Steele <david(at)pgmasters(dot)net> wrote:
>
>> On 3/23/18 12:14 PM, Teodor Sigaev wrote:
>> >
>> > Thank you, pushed
>>
>>
> Is it just me or the newly added test in 010_pg_basebackup.pl failing for
> others too?
>
> # Failed test 'unlogged main fork not in backup'
> # at t/010_pg_basebackup.pl line 112.
> t/010_pg_basebackup.pl ... 86/87 # Looks like you failed 1 test of 87.
>
>
This one-liner patch fixes it for me.

Thanks,
Pavan

--
Pavan Deolasee http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
0001_pg_basebackup_fix.patch application/octet-stream 632 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Craig Ringer 2018-03-26 08:27:23 Function to get a txn's replication origin
Previous Message Pavan Deolasee 2018-03-26 07:36:09 Re: Faster inserts with mostly-monotonically increasing values