Re: PATCH: Exclude unlogged tables from base backups

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>
Cc: David Steele <david(at)pgmasters(dot)net>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, Adam Brightwell <adam(dot)brightwell(at)crunchydata(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Exclude unlogged tables from base backups
Date: 2018-03-26 11:46:28
Message-ID: CAD21AoB+ot=SCuA-N3wdUxru3BgkehUyG8_8kqmmEiBsOoTrzA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Mar 26, 2018 at 4:52 PM, Pavan Deolasee
<pavan(dot)deolasee(at)gmail(dot)com> wrote:
>
>
> On Mon, Mar 26, 2018 at 1:03 PM, Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>
> wrote:
>>
>> On Fri, Mar 23, 2018 at 9:51 PM, David Steele <david(at)pgmasters(dot)net> wrote:
>>>
>>> On 3/23/18 12:14 PM, Teodor Sigaev wrote:
>>> >
>>> > Thank you, pushed
>>>
>>
>> Is it just me or the newly added test in 010_pg_basebackup.pl failing for
>> others too?
>>
>> # Failed test 'unlogged main fork not in backup'
>> # at t/010_pg_basebackup.pl line 112.
>> t/010_pg_basebackup.pl ... 86/87 # Looks like you failed 1 test of 87.
>>
>
> This one-liner patch fixes it for me.
>

Isn't this issue already fixed by commit
d0c0c894533f906b13b79813f02b2982ac675074?

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2018-03-26 11:54:13 Re: [HACKERS] Partition-wise aggregation/grouping
Previous Message Amit Langote 2018-03-26 11:42:57 Re: [HACKERS] path toward faster partition pruning