Re: Faster inserts with mostly-monotonically increasing values

From: Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>
To: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
Cc: Claudio Freire <klaussfreire(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Simon Riggs <simon(dot)riggs(at)2ndquadrant(dot)com>
Subject: Re: Faster inserts with mostly-monotonically increasing values
Date: 2018-03-26 07:36:09
Message-ID: CABOikdObQL6at==YM0rd+PdqsGJ=MDq6Krfd92gBsexxHFLw5Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Mar 25, 2018 at 6:00 AM, Andrew Dunstan <
andrew(dot)dunstan(at)2ndquadrant(dot)com> wrote:

> On Fri, Mar 23, 2018 at 8:27 PM, Pavan Deolasee
> <pavan(dot)deolasee(at)gmail(dot)com> wrote:
> >>
> >>
> >> I would probably just have a few regression lines that should be sure
> >> to exercise the code path and leave it at that.
> >>
> >
> > I changed the regression tests to include a few more scenarios, basically
> > using multi-column indexes in different ways and they querying rows by
> > ordering rows in different ways. I did not take away the vacuum and I
> > believe it will actually help the tests by introducing some fuzziness in
> the
> > tests i.e. if the vacuum does not do its job, we might execute a
> different
> > plan and ensure that the output remains unchanged.
> >
>
>
> If we're going to keep the vacuums in there, do we need to add a wait
> barrier like Claudio suggested upthread?
>
>
I don't think we need the wait barrier since we're no longer printing the
explain plan. In the worst case, the vacuum may not get to set pages
all-visible, thus planner choosing something other than an index-only-scan,
but I guess that fuzziness actually helps the regression tests. That way we
get confirmation regarding the final result irrespective of the plan
chosen.

Thanks,
Pavan

--
Pavan Deolasee http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavan Deolasee 2018-03-26 07:52:57 Re: PATCH: Exclude unlogged tables from base backups
Previous Message Kyotaro HORIGUCHI 2018-03-26 07:34:47 Re: PQHost() undefined behavior if connecting string contains both host and hostaddr types