Re: Bug report: OIDs, roles and Windows (signedness issue?)

2014-02-26 13:27 GMT+09:00 Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>:

> Done.
> Checked-in in the master and REL-1_18_0_PATCHES branch.
>
>
Many thanks. If someone can provide a Windows build, I can
verify it in the environment where the issue occurred.

Regards

Ian Barwick

>
>
On Wed, Feb 26, 2014 at 9:42 AM, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com
> > wrote:
>
>> On Wed, Feb 26, 2014 at 4:28 AM, Ian Lawrence Barwick <barwick(at)gmail(dot)com>wrote:
>>
>>> Just wondering - is anything happening with this patch?
>>>
>> I was waiting for other hackers for their response.
>> I will check-in the patch as nobody objected.
>>
>> Thanks for the reminder though.
>>
>>>
>>> Regards
>>>
>>> Ian Barwick
>>>
>>> 2014-02-05 19:02 GMT+09:00 Ian Lawrence Barwick <barwick(at)gmail(dot)com>:
>>>
>>> Thanks for the update .
>>>>
>>>> Regards
>>>>
>>>> Ian Barwick
>>>>
>>>>
>>>> 2014-02-05 Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>:
>>>>
>>>> Dave,
>>>>>
>>>>> The patch, sent by Ian Lawrence, looks good me.
>>>>> I also found some other places, where the similar changes were
>>>>> required (specially in debugger code).
>>>>> I've attached the combined patch (debugger changes and Ian's patch).
>>>>>
>>>>> If nobody has any objection, I will check-in the patch on both
>>>>> REL-1_18_0_PATCHES and master branch.
>>>>>
>>>>>
>>>>> On Fri, Jan 10, 2014 at 2:11 PM, Ian Lawrence Barwick <
>>>>> barwick(at)gmail(dot)com> wrote:
>>>>>
>>>>>> 2014/1/10 Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
>>>>>>
>>>>>>> Sorry - it was missed due to busy schedule.
>>>>>>> I will take a look at it.
>>>>>>>
>>>>>>> Thanks for the reminder.
>>>>>>>
>>>>>>
>>>>>> No worries, thanks for replying so quickly.
>>>>>>
>>>>>> Regards
>>>>>>
>>>>>> Ian Barwick
>>>>>>
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Fri, Jan 10, 2014 at 1:36 PM, Ian Lawrence Barwick <
>>>>>>> barwick(at)gmail(dot)com> wrote:
>>>>>>>
>>>>>>>> 2013/11/22 Ian Lawrence Barwick <barwick(at)gmail(dot)com>:
>>>>>>>> > 2013/11/22 Ian Lawrence Barwick <barwick(at)gmail(dot)com>:
>>>>>>>> >
>>>>>>>> >>>
>>>>>>>> >>> BTW other objects (tables, schemas etc.) with OIDs greater than
>>>>>>>> 256^4/2 - 1
>>>>>>>> >>> don't seem to be affected by this.
>>>>>>>> >>
>>>>>>>> >> It's been a while since I've looked at the pgAdmin source, but
>>>>>>>> some wild
>>>>>>>> >> grepping shows that in:
>>>>>>>> >>
>>>>>>>> >> pgadmin/schema/pgRole.cpp
>>>>>>>> >>
>>>>>>>> >> the role OID is set with:
>>>>>>>> >>
>>>>>>>> >> role->iSetOid(roles->GetLong(wxT("oid")));
>>>>>>>> >>
>>>>>>>> >> whereas almost everywhere else it's set with GetOid(), e.g.
>>>>>>>> >>
>>>>>>>> >> table->iSetOid(tables->GetOid(wxT("oid")));
>>>>>>>> >>
>>>>>>>> >> which may or may not have something to do with the issue.
>>>>>>>> >
>>>>>>>> > If that is the problem, then here's a patch. Untested as I don't
>>>>>>>> have a Windows
>>>>>>>> > build environment available, though I might be able to cobble one
>>>>>>>> together
>>>>>>>> > next week.
>>>>>>>>
>>>>>>>> Just wondering - has anyone been able to look into this?
>>>>>>>> Unfortunately I still
>>>>>>>> don't have a Windows build environment available to test.
>>>>>>>>
>>>>>>>>
>>>>>>>> Regards
>>>>>>>>
>>>>>>>> Ian Barwick
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Sent via pgadmin-hackers mailing list (
>>>>>>>> pgadmin-hackers(at)postgresql(dot)org)
>>>>>>>> To make changes to your subscription:
>>>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> --
>>>>>>>
>>>>>>> Thanks & Regards,
>>>>>>>
>>>>>>> Ashesh Vashi
>>>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> *http://www.linkedin.com/in/asheshvashi*<http://www.linkedin.com/in/asheshvashi>
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> --
>>>>>
>>>>> Thanks & Regards,
>>>>>
>>>>> Ashesh Vashi
>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com>
>>>>>
>>>>>
>>>>>
>>>>> *http://www.linkedin.com/in/asheshvashi*<http://www.linkedin.com/in/asheshvashi>
>>>>>
>>>>
>>>>
>>>
>>
>>
>> --
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com>
>>
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*<http://www.linkedin.com/in/asheshvashi>
>>
>
>
>
> --
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com>
>
>
>
> *http://www.linkedin.com/in/asheshvashi*<http://www.linkedin.com/in/asheshvashi>
>