| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: src/interfaces/libpq shipping nmake-related Makefiles |
| Date: | 2017-04-11 02:18:03 |
| Message-ID: | CAB7nPqTjoMs9AWdTdJ+1-2ACPaxZQd0PAOR4z615xiTVo1M3xg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Apr 11, 2017 at 1:45 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>>>>> Are these votes for getting rid of both win32.mak and bcc32.mak?
>
>> PFA a patch that does this. Did I miss something? :)
>
> Perhaps we should get rid of the WIN32_ONLY_COMPILER symbol altogether;
> given this patch, "#ifdef WIN32_ONLY_COMPILER" could be replaced by
> "#ifdef _MSC_VER".
That's here in the patch for people wondering:
-#if defined(_MSC_VER) || defined(__BORLANDC__)
+#if defined(_MSC_VER)
#define WIN32_ONLY_COMPILER
#endif
+1 for the renaming.
> Or maybe rename it to something else --- I'm not sure what, but
> I've always found that symbol rather confusing.
No complains here as well. Thanks for the patch.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Osahon Oduware | 2017-04-11 02:51:20 | PostGIS Out-DB Raster Not Behaving As Expected |
| Previous Message | Noah Misch | 2017-04-11 02:11:15 | Re: error handling in RegisterBackgroundWorker |