| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: src/interfaces/libpq shipping nmake-related Makefiles |
| Date: | 2017-04-10 16:45:19 |
| Message-ID: | 15260.1491842719@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Magnus Hagander <magnus(at)hagander(dot)net> writes:
>>>> Are these votes for getting rid of both win32.mak and bcc32.mak?
> PFA a patch that does this. Did I miss something? :)
Perhaps we should get rid of the WIN32_ONLY_COMPILER symbol altogether;
given this patch, "#ifdef WIN32_ONLY_COMPILER" could be replaced by
"#ifdef _MSC_VER".
Or maybe rename it to something else --- I'm not sure what, but
I've always found that symbol rather confusing.
Looks good other than that nitpick.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-04-10 16:47:50 | Re: tuple-routing and constraint violation error message, revisited |
| Previous Message | Fujii Masao | 2017-04-10 16:39:06 | Re: max_sync_workers_per_subscription is missing in postgresql.conf |