| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | MauMau <maumau307(at)gmail(dot)com> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Improvement of versioning on Windows, take two |
| Date: | 2014-08-14 06:59:57 |
| Message-ID: | CAB7nPqTeGq_uUnLY2CLMpPqymtrGQkcY76Luw2GtOTW+qhSrFw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 12, 2014 at 11:47 PM, MauMau <maumau307(at)gmail(dot)com> wrote:
> From: "Michael Paquier" <michael(dot)paquier(at)gmail(dot)com>
> Yes, the build succeeded. I confirmed that the following files have version
> info. However, unlike other files, they don't have file description. Is
> this intended?
> bin\isolationtester.exe
> bin\pg_isolation_regress
> bin\pg_regress.exe
> bin\pg_regress_ecpg.exe
> bin\zic.exe
No... But after some additional hacking on this, I have been able to
complete that. This has for example required the addition of a new
function called AddUtilityResourceFile in Project.pm that is able to
scan a Makefile within a given folder and to extract PGFILEDESC and
PGAPPICON values that are then used to create a win32ver.rc in the
targetted build folder. Note that on MinGW all those exe/dll had file
description and version number even with previous version.
> lib\regress.dll
With MinGW, this had no file description and no version number. Of
course that was the same with MSVC. Fixed.
> lib\dict_snowball.dll has no version properties.
On MSVC there were no file description and no version number. On
MinGW, I saw a version number. Thanks for spotting that, I've fixed
it.
Regards,
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 20140814_win_version_v3.patch | text/x-patch | 8.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2014-08-14 07:03:57 | Re: pg_dump bug in 9.4beta2 and HEAD |
| Previous Message | Tom Lane | 2014-08-14 06:50:02 | Re: strncpy is not a safe version of strcpy |