From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com> |
Cc: | Stephen Frost <sfrost(at)snowman(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thom Brown <thom(at)linux(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Add support for restrictive RLS policies |
Date: | 2016-10-03 02:47:56 |
Message-ID: | CAB7nPqTbu9ALOMs-OemNA8ZzCWXd2q4A8T5jobDK5a+korNZxw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Sep 29, 2016 at 7:18 PM, Jeevan Chalke
<jeevan(dot)chalke(at)enterprisedb(dot)com> wrote:
> Hi Stephen,
>
>
>> > 4. It will be good if we have an example for this in section
>> > "5.7. Row Security Policies"
>>
>> I haven't added one yet, but will plan to do so.
>>
> I think you are going to add this in this patch itself, right?
>
> I have reviewed your latest patch and it fixes almost all my review
> comments.
> Also I am agree with your responses for couple of comments like response on
> ALTER POLICY and tab completion. No issues with that.
>
> However in documentation, PERMISSIVE and RESTRICTIVE are actually literals
> and not parameters as such. Also can we combine these two options into one
> like below (similar to how we document CASCADE and RESTRICT for DROP
> POLICY):
>
> <varlistentry>
> <term><literal>PERMISSIVE</literal></term>
> <term><literal>RESTRICTIVE</literal></term>
>
> <listitem>
> <para>
> ... explain PERMISSIVE ...
> </para>
> <para>
> ... explain RESTRICTIVE ...
> </para>
> </listitem>
> </varlistentry>
>
> Apart from this changes look excellent to me.
I have moved that to next CF, my guess is that Stephen is going to
update soon and the activity is fresh.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2016-10-03 02:49:22 | Re: Logical Replication WIP |
Previous Message | Michael Paquier | 2016-10-03 02:40:55 | Re: Notice lock waits |