Re: Collection of memory leaks for ECPG driver

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Collection of memory leaks for ECPG driver
Date: 2015-06-13 03:32:44
Message-ID: CAB7nPqTSJ6nBYz_i6v93=3V=UC6BOE-htm3-PTks7O8xM3MpZw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jun 12, 2015 at 10:01 PM, Michael Meskes <meskes(at)postgresql(dot)org> wrote:
> On Mon, Jun 08, 2015 at 10:50:25PM +0900, Michael Paquier wrote:
> Right, that's because they were developed before free received the safeguard, or the programmer simply didn't know at that point in time. Unless I'm mistaken we have other code that only calls free() without an additional safeguard, so why shuld ecpglib be special? If you don't like it using both approaches, feel free to remove the check in the other case. :)

Well, I can send patches...

> More seriously, though, does anyone know of any platform where free(NULL) is *not* a noop?

I recall reading that some past versions of SunOS crashed, but it is
rather old...
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2015-06-13 03:47:09 Re: Time to fully remove heap_formtuple() and friends?
Previous Message Amit Kapila 2015-06-13 02:55:55 Re: 9.5 release notes