Re: split builtins.h to quote.h

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, Noah Misch <noah(at)leadboat(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: split builtins.h to quote.h
Date: 2014-10-14 08:00:00
Message-ID: CAB7nPqT8Yb_2ab5gCA5u-u=JfdKuQ3+HCnrvV9+k9Juc0=Pj0w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Oct 13, 2014 at 11:14 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> IMHO, putting some prototypes for a .c file in one header and others
> in another header is going to make it significantly harder to figure
> out which files you need to #include when. Keeping a simple rule there
> seems essential to me.

OK. Let's make the separation clear then. The attached does so, and
moves the remaining quote_* functions previously in builtins.h to
quote.h. I am adding it to the upcoming CF for tracking the effort on
it.
--
Michael

Attachment Content-Type Size
20141012_quote_h_refactor_v3.patch text/x-diff 18.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2014-10-14 08:38:58 Re: Commitfest progress, or lack thereof
Previous Message Heikki Linnakangas 2014-10-14 07:18:36 Re: [9.4 bug] The database server hangs with write-heavy workload on Windows