From: | Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Noah Misch <noah(at)leadboat(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: split builtins.h to quote.h |
Date: | 2014-11-06 17:12:36 |
Message-ID: | 545BAC04.1080603@dalibo.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Le 14/10/2014 10:00, Michael Paquier a écrit :
> On Mon, Oct 13, 2014 at 11:14 PM, Robert Haas
> <robertmhaas(at)gmail(dot)com> wrote:
>>
>> IMHO, putting some prototypes for a .c file in one header and
>> others in another header is going to make it significantly harder
>> to figure out which files you need to #include when. Keeping a
>> simple rule there seems essential to me.
>
> OK. Let's make the separation clear then. The attached does so,
> and moves the remaining quote_* functions previously in builtins.h
> to quote.h. I am adding it to the upcoming CF for tracking the
> effort on it.
>
>
>
>
Hi Michael,
I just reviewed this patch :
* applies cleanly to master(d2b8a2c7)
* all regression tests pass
As it's only moving functions from builtins.h to quote.h and update
impacted files, nothing special to add.
It will probably break some user extensions using quote_* functions.
Otherwise it looks ready to commit.
Regards.
- --
Julien Rouhaud
http://dalibo.com - http://dalibo.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iQEcBAEBAgAGBQJUW6wEAAoJELGaJ8vfEpOqCn4H/AydFB5ERI0x9R6l8T/Qkx9/
Tm0ZgSSsfG39lHkbspZaUwTxmNPam1+EueQrw2VQcT3JXjWaHWvurWjFDBdSi8Ar
fgcD4WOTcyenxsckq5/XwT++ZfOZa1h2qBABoC4nx1qcO4pNBW51ywL11Fmcb7O8
CkwKZ3FfUlVFLsh2Novqa7HtEWdi872zzb4TSxQjsShMuFNX/6PF6RFJVZAy61VA
sbVQ/0rRQ9bOcJgh+DDaIMVQAnOUWsvYdR9VbRCbgcZuBlZKeW7gt9qGgevgjcun
PYB+ZuSC92WiS9y3OhcGKp9cYQpcsOD5ZDxe1Cw7q4YNZNgUtbKpDW6GsTC+vp0=
=NH1j
-----END PGP SIGNATURE-----
From | Date | Subject | |
---|---|---|---|
Next Message | Jim Nasby | 2014-11-06 17:28:03 | Re: Tweaking Foreign Keys for larger tables |
Previous Message | Robert Haas | 2014-11-06 15:49:37 | Re: group locking: incomplete patch, just for discussion |