From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: The real reason why TAP testing isn't ready for prime time |
Date: | 2015-06-19 22:06:40 |
Message-ID: | CAB7nPqT4ZPSzh0y30Ha0HK32_8mKeoQvEvHTqxP5Maoi-MFRjg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Jun 19, 2015 at 11:45 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
>> Attached is a patch fixing those problems and improving the log
>> facility as it really helped me out with those issues. The simplest
>> fix would be to include the -w switch missing in the tests of
>> pg_rewind and pg_ctl though.
>
> I agree with adding the -w switch and will go do that. As far as the
> rest of this patch goes, it seems like it could be made less invasive
> if the logs got dumped into a subdirectory of tmp_check rather than
> adding another top-level directory that has to be cleaned?
tmp_check remains unused since dcae5fac (missing something perhaps?),
but I guess we could use it again to save the logs in it, and have
pg_rewind do the same.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Vik Fearing | 2015-06-19 23:08:56 | Insufficient locking for ALTER DEFAULT PRIVILEGES |
Previous Message | Michael Paquier | 2015-06-19 21:53:51 | Re: The real reason why TAP testing isn't ready for prime time |