Re: The real reason why TAP testing isn't ready for prime time

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: The real reason why TAP testing isn't ready for prime time
Date: 2015-06-20 08:48:31
Message-ID: CAB7nPqQmi2zp2arwqLug34D77woNP4Wd71zKKK55Ar5mBAn7Vw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jun 20, 2015 at 7:06 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
>> As far as the
>> rest of this patch goes, it seems like it could be made less invasive
>> if the logs got dumped into a subdirectory of tmp_check rather than
>> adding another top-level directory that has to be cleaned?
>
> tmp_check remains unused since dcae5fac (missing something perhaps?),
> but I guess we could use it again to save the logs in it, and have
> pg_rewind do the same.

OK, so here is an updated patch. All the logs are saved in
tmp_check/log, and each log file is named with the name of the file
that launched the test to facilitate its identification. I noticed at
the same time that some commands were called in silent mode. I removed
that and now what they output is written as well in the log files.
Regards,
--
Michael

Attachment Content-Type Size
20150620_tap_improve_logs_v3.patch application/x-patch 15.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Prakash Itnal 2015-06-20 13:32:25 Re: Auto-vacuum is not running in 9.1.12
Previous Message Fabien COELHO 2015-06-20 07:22:53 Re: pgbench - allow backslash-continuations in custom scripts