| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andreas Karlsson <andreas(at)proxel(dot)se>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Broken SSL tests in master |
| Date: | 2016-12-02 01:31:38 |
| Message-ID: | CAB7nPqT=C=wkLHu79QjZPLKO8vEi6n=b0JjezCALeUR6Uv=0gw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Dec 2, 2016 at 10:26 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
>> Would it be better to return NULL instead then.
>
> That would likely just result in application core dumps.
> See notes for commit 490cb21f7.
That's 40cb21f7 actually. Thanks for the pointer.
> I think we've established an expectation
> that only a NULL argument will elicit a NULL return from PQhost.
OK, the current behavior wins then.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2016-12-02 01:32:10 | Re: Logical Replication WIP |
| Previous Message | Peter Eisentraut | 2016-12-02 01:29:49 | pgsql: Use latch instead of select() in walreceiver |