| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andreas Karlsson <andreas(at)proxel(dot)se>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Broken SSL tests in master |
| Date: | 2016-12-02 01:26:49 |
| Message-ID: | 25490.1480642009@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> On Fri, Dec 2, 2016 at 8:36 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> Correct, but I'm defining that as user error. If hostaddr is
>> specified, host is not used to decide what to connect to, so it makes
>> no sense for it to be a string of multiple host names. If we allowed
>> multiple hostaddrs, as has been proposed, then we'd need to be more
>> clever about this.
> Would it be better to return NULL instead then.
That would likely just result in application core dumps.
See notes for commit 490cb21f7. I think we've established an expectation
that only a NULL argument will elicit a NULL return from PQhost.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-12-02 01:28:11 | Re: Proposal for changes to recovery.conf API |
| Previous Message | Michael Paquier | 2016-12-02 01:16:53 | Re: Broken SSL tests in master |