Re: [HACKERS] create_unique_path and GEQO

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] create_unique_path and GEQO
Date: 2017-11-30 03:20:13
Message-ID: CAB7nPqT+uEKG61o3JNJEHFSMk+CtEbhnPCXh5FMUR49ceQQ37g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Mar 24, 2017 at 10:50 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> writes:
>>> Do you have test case, which can reproduce the issue you
>>> explained above?
>
>> No. It would require some surgery in standard_planner() to measure the
>> memory consumed in the planner context OR build the code with
>> SHOW_MEMORY_STATS defined and dump memory context statistics and check
>> planner context memory usage. I don't think I can produce a testcase
>> quickly right now. But then, I think the problem is quite apparent
>> from the code inspection alone, esp. comparing what mark_dummy_rel()
>> does with what create_unique_path() is doing.
>
> Yeah. I think the code in mark_dummy_rel is newer and better-thought-out
> than what's in create_unique_path. It probably makes sense to change over.

This has remained unanswered for more than 8 months, so I am marking
this patch as returned with feedback.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2017-11-30 03:23:58 Re: [HACKERS] eval_const_expresisions and ScalarArrayOpExpr
Previous Message Michael Paquier 2017-11-30 03:16:41 Re: [HACKERS] pg_serial early wraparound