From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: plpgsql test layout |
Date: | 2017-12-12 00:29:06 |
Message-ID: | CAB7nPqSv5spkemChzp9ODksoGqwGcrwuOmf2tseT=Qb8zDFChQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Dec 12, 2017 at 5:11 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
>> On 12/7/17 15:21, Pavel Stehule wrote:
>>> 2017-12-07 20:08 GMT+01:00 Peter Eisentraut
>>> <peter(dot)eisentraut(at)2ndquadrant(dot)com
>>> <mailto:peter(dot)eisentraut(at)2ndquadrant(dot)com>>:
>>>> Here is a first attempt.
>
>>> looks ok
>
>> Any other thoughts on this? If not, I'd like to commit it, give the
>> buildfarm a run at it (looking at the client code, it should be fine),
>> and then rebase some ongoing work on top of it.
>
> No particular objection. Does the MSVC infrastructure need to be
> taught about it?
If I read vcregress.pl correctly, it seems to me that you need to do
more with MSVC (see plcheck). The tests would kick if sql/ and
expected/ are found, and the test list is fetched by looking at
REGRESSION in the test files. However plpgsql code has an additional
src/ folder which would cause the tests to not execute. If plpgsql
code was moved on folder down then the tests would execute properly.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Masahiko Sawada | 2017-12-12 00:40:56 | Re: User defined data types in Logical Replication |
Previous Message | Tsunakawa, Takayuki | 2017-12-11 23:44:30 | RE: Added PostgreSQL internals learning materials in Developer FAQ |