From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Catalin Iacob <iacobcatalin(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Adam Brightwell <adam(dot)brightwell(at)crunchydatasolutions(dot)com>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, dinesh kumar <dineshkumar02(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: proposal: multiple psql option -c |
Date: | 2015-12-06 13:56:22 |
Message-ID: | CAB7nPqSM8DymMe6OLScZivNHkQofKbY=wHX9RTGBWFF8RCAj_A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Dec 4, 2015 at 11:47 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Wed, Dec 2, 2015 at 12:33 AM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>>> Yeah, I don't think that's a big issue either to be honest. The code
>>> is kept consistent a maximum with what is there previously.
>>>
>>> Patch is switched to ready for committer.
>>
>> perfect
>>
>> Thank you very much to all
>
> I did some edits on this patch and was all set to commit it when I ran
> the regression tests and discovered that this breaks 130 out of the
> 160 regression tests. Allow me to suggest that before submitting a
> patch, or marking it ready for commiter, you test that 'make check'
> passes.
Mea culpa. I thought I did a check-world run... But well...
> For the most part, the cleanups in this version are just cosmetic: I
> fixed some whitespace damage, and reverted some needless changes to
> the psql references page that were whitespace-only adjustments. In a
> few places, I tweaked documentation or comment language. I also
> hoisted the psqlrc handling out of an if statement where it was the
> same in both branches. Other than that, this version is, I believe,
> the same as Pavel's last version.
Thanks, I looked at that again and problem is fixed as attached.
--
Michael
Attachment | Content-Type | Size |
---|---|---|
20151206_psql_commands_v3.patch | binary/octet-stream | 18.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2015-12-06 14:27:35 | Re: proposal: multiple psql option -c |
Previous Message | David Rowley | 2015-12-06 09:26:57 | Re: [PATCH] Equivalence Class Filters |