On Mon, Mar 17, 2014 at 10:54 PM, Heikki Linnakangas
<hlinnakangas(at)vmware(dot)com> wrote:
> On 03/17/2014 03:18 PM, Heikki Linnakangas wrote:
>> Hmm, PG_CONFIG is currently tied to the --with-libpq configure option,
>> so that's only available if you build the driver with libpq. Would need
>> to separate that into a separate option.
>
>
> Then again, if building with libpq, then there's no reason to *not* use the
> PG_CONFIG from configure. Committed a patch to do that. If you configure
> --without-libpq, then you still need to pass the path to PG_CONFIG manually
> at the command line when building the regression suite, i.e "cd test; make
> installcheck PG_CONFIG=<path>". But it's still an improvement that you don't
> need it when building with libpq, which is the default.
If the code tree of pgodbc gains in complexity in the future,
something that I doubt will happen in a close future, we could still
revisit that. But for now, what you have pushed is fine and enough
IMO. So let's stick with that.
--
Michael