Re: Adding flag LDFLAGS for compilation of regression tests

On 03/17/2014 03:18 PM, Heikki Linnakangas wrote:
> On 03/17/2014 01:24 PM, Michael Paquier wrote:
>> On Mon, Mar 17, 2014 at 5:32 PM, Heikki Linnakangas
>> <hlinnakangas(at)vmware(dot)com> wrote:
>>> Actually, we could just move test/Makefile to test/Makefile.in, and let
>>> configure set the LDFLAGS/CFLAGS variables directly in test/Makefile.
>>>
>>> I pushed a patch to do that. It doesn't do anything automatic about
>>> PG_CONFIG; it would still be nice to add a configure flag for that.
>> configure already sets PG_CONFIG, so we could do like in the patch
>> attached and add a flag in test/Makefile.in similarly to CFLAGS and
>> LDFLAGS.
>
> Hmm, PG_CONFIG is currently tied to the --with-libpq configure option,
> so that's only available if you build the driver with libpq. Would need
> to separate that into a separate option.

Then again, if building with libpq, then there's no reason to *not* use
the PG_CONFIG from configure. Committed a patch to do that. If you
configure --without-libpq, then you still need to pass the path to
PG_CONFIG manually at the command line when building the regression
suite, i.e "cd test; make installcheck PG_CONFIG=<path>". But it's still
an improvement that you don't need it when building with libpq, which is
the default.

- Heikki