Re: Small patch: Change calling convention for ShmemInitHash (and fix possible bug)

On Fri, Mar 25, 2016 at 9:17 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Thu, Mar 24, 2016 at 9:50 AM, Aleksander Alekseev
> <a(dot)alekseev(at)postgrespro(dot)ru> wrote:
>> Currently this procedure has two arguments --- init_size and max_size.
>> But since shared hash tables have fixed size there is little sense to
>> pass two arguments. In fact currently ShmemInitHash is always called
>> with init_size == max_size with only one exception, InitLocks procedure
>> (see lock.c), which I believe is actually a bug.
>
> No, I think we left it that way on purpose. I don't remember the
> discussion exactly, but I don't think it's hurting anything.

My instinct is telling me that this is useful in this shape for
plugins, and that it has been designed on purpose for that.
--
Michael