From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Robert Haas <rhaas(at)postgresql(dot)org> |
Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [COMMITTERS] pgsql: Show more processes in pg_stat_activity. |
Date: | 2017-03-27 02:20:17 |
Message-ID: | CAB7nPqRcL3ENHnkLu7jxo9f+yJXHXpPjgaZBb5zZdoR2ygzEhQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Mon, Mar 27, 2017 at 11:07 AM, Robert Haas <rhaas(at)postgresql(dot)org> wrote:
> Show more processes in pg_stat_activity.
>
> Previously, auxiliary processes and background workers not connected
> to a database (such as the logical replication launcher) weren't
> shown. Include them, so that we can see the associated wait state
> information. Add a new column to identify the processes type, so that
> people can filter them out easily using SQL if they wish.
>
> Before this patch was written, there was discussion about whether we
> should expose this information in a separate view, so as to avoid
> contaminating pg_stat_activity with things people might not want to
> see. But putting everything in pg_stat_activity was a more popular
> choice, so that's what the patch does.
>
> Kuntal Ghosh, reviewed by Amit Langote and Michael Paquier. Some
> revisions and bug fixes by me.
- /* Report to pgstat that this process is a WAL sender */
- pgstat_report_activity(STATE_RUNNING, "walsender");
+ /* Report to pgstat that this process is running */
+ pgstat_report_activity(STATE_RUNNING, NULL);
Perhaps this bit should just be removed? We added it to make the
process show in pg_stat_activity, and with this patch it does show up
even without this call.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Gierth | 2017-03-27 03:47:00 | pgsql: Support hashed aggregation with grouping sets. |
Previous Message | Robert Haas | 2017-03-27 02:18:10 | pgsql: Fix comment. |
From | Date | Subject | |
---|---|---|---|
Next Message | Haribabu Kommi | 2017-03-27 02:27:07 | Re: pg_stat_wal_write statistics view |
Previous Message | Robert Haas | 2017-03-27 02:18:12 | Re: comments in hash_alloc_buckets |