Re: comments in hash_alloc_buckets

On Sat, Mar 25, 2017 at 3:28 AM, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> wrote:
>>> While working on - [1], I realised that the following comments in
>>> _hash_alloc_buckets() needs to be corrected.
>>>
>>> /*
>>> * Initialize the freed overflow page. Just zeroing the page won't work,
>>> * See _hash_freeovflpage for similar usage.
>>> */
>>> _hash_pageinit(page, BLCKSZ);
>>>
>>> Attached is the patch that corrects above comment. Thanks.
>>>
>>
>> - * Initialize the freed overflow page. Just zeroing the page won't work,
>> + * Initialize the last page in hash index.
>>
>> I think saying ".. last page in hash index" sounds slightly awkward as
>> this is the last page for current split point, how about just
>> "Initialize the page. ..."
>
> Yes, I mean just adding "Initialize the page. ..." looks more simple
> and correct. Attached is the patch with similar comment.

Committed with a punctuation and formatting adjustment.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company