Re: Re: [COMMITTERS] Re: pgsql: Convert contrib/seg's bool-returning SQL functions to V1 call co

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Noah Misch <noah(at)leadboat(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] Re: pgsql: Convert contrib/seg's bool-returning SQL functions to V1 call co
Date: 2016-04-28 05:22:39
Message-ID: CAB7nPqRHW+S1V=W+FeWO3jUZ9-EEDeotAnov8YqS2fjFLfvYGA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Wed, Apr 27, 2016 at 10:53 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Now, if VS2015 actually has broken bool-returning V0, the argument for
> keeping it going becomes a lot weaker. But at this point I suspect
> strongly that that's not what happened but rather we've got a faulty
> bool cast there, which if true is something we need to fix regardless
> of any considerations about V0. Would someone please try the experiment
> requested upthread?

I just gave it a try. And by using PG_1_BYTE() the tests of
contrib/seg/ are passing.
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-04-28 05:34:19 Re: Re: [COMMITTERS] Re: pgsql: Convert contrib/seg's bool-returning SQL functions to V1 call co
Previous Message Tom Lane 2016-04-27 22:50:01 Re: Re: [COMMITTERS] pgsql: Modify the isolation tester so that multiple sessions can wait.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-04-28 05:34:19 Re: Re: [COMMITTERS] Re: pgsql: Convert contrib/seg's bool-returning SQL functions to V1 call co
Previous Message Michael Paquier 2016-04-28 04:46:39 Re: Shared memory and processes