| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Noah Misch <noah(at)leadboat(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] Re: pgsql: Convert contrib/seg's bool-returning SQL functions to V1 call co |
| Date: | 2016-04-28 05:34:19 |
| Message-ID: | 18276.1461821659@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> On Wed, Apr 27, 2016 at 10:53 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Now, if VS2015 actually has broken bool-returning V0, the argument for
>> keeping it going becomes a lot weaker. But at this point I suspect
>> strongly that that's not what happened but rather we've got a faulty
>> bool cast there, which if true is something we need to fix regardless
>> of any considerations about V0. Would someone please try the experiment
>> requested upthread?
> I just gave it a try. And by using PG_1_BYTE() the tests of
> contrib/seg/ are passing.
Thanks! Barring objections, I will revert c8e81afc60093b19 tomorrow
and instead fix DatumGetBool.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2016-04-28 12:32:17 | pgsql: pg_upgrade: Fix indentation of if() block |
| Previous Message | Michael Paquier | 2016-04-28 05:22:39 | Re: Re: [COMMITTERS] Re: pgsql: Convert contrib/seg's bool-returning SQL functions to V1 call co |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2016-04-28 06:13:53 | Re: GIN data corruption bug(s) in 9.6devel |
| Previous Message | Michael Paquier | 2016-04-28 05:22:39 | Re: Re: [COMMITTERS] Re: pgsql: Convert contrib/seg's bool-returning SQL functions to V1 call co |