From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_rewind and log messages |
Date: | 2015-04-07 07:33:47 |
Message-ID: | CAB7nPqRGv2z7LKXZ8p+qyrSB5bL3Y0Oj9-81tDA6dwzAQChnSw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Apr 7, 2015 at 4:16 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Mon, Apr 6, 2015 at 10:01 PM, Alvaro Herrera
> <alvherre(at)2ndquadrant(dot)com> wrote:
>> Fujii Masao wrote:
>>> On Mon, Apr 6, 2015 at 5:33 PM, Michael Paquier
>>> <michael(dot)paquier(at)gmail(dot)com> wrote:
>>> > On Mon, Apr 6, 2015 at 1:41 PM, Michael Paquier wrote:
>>> >> I guess that you are working on a patch? If not, you are looking for one?
>>> >
>>> > Code-speaking, this gives the patch attached.
>>>
>>> Thanks! Here are the review comments:
>>>
>>> I'm not familiar with native language support (sorry), but don't we need to
>>> add the shortcut of gettext into every calls of pg_log and pg_fatal, e.g.,
>>> change pg_fatal("xxx") to pg_fatal(_("xxx"))? I know that fprintf() in
>>> pg_Log_v() has such shortcut, but I'm not sure if that's enough or not.
>>
>> It's not necessary for pg_fatal and the like, because those functions
>> are marked to have their first argument automatically translated in
>> nls.mk. This means that the string literal is automatically extracted
>> into pg_rewind.pot for translators. Of course, the function itself must
>> call _() (or some variant thereof) to actually fetch the translated
>> string at run time.
>
> Understood. Thanks!
>
> BTW, as far as I read pg_rewind's nls.mk correctly, it also has two problems.
>
> (1) file_ops.c should be added into GETTEXT_FILES.
And ../../common/restricted_tokens.c.
> (2) pg_log should be pg_log:2 in GETTEXT_TRIGGERS
Seems so.
--
Michael
Attachment | Content-Type | Size |
---|---|---|
0001-Fix-process-handling-of-pg_rewind.patch | text/x-patch | 2.7 KB |
0002-Fix-inconsistent-handling-of-logs-in-pg_rewind.patch | text/x-patch | 35.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2015-04-07 07:37:40 | Re: pg_rewind and log messages |
Previous Message | Fujii Masao | 2015-04-07 07:33:37 | Re: pg_rewind and log messages |