From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_rewind and log messages |
Date: | 2015-04-07 07:37:40 |
Message-ID: | CAB7nPqQLPN2huz8we6DYu97=A6c5+4zv_ivw=YprS2NPkLenng@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Apr 7, 2015 at 4:33 PM, Fujii Masao wrote:
> Isn't the term "PostgreSQL superuser" confusing? I'm afraid that a user might
> confuse "PostgreSQL superuser" with a database superuser. I see you just
> borrowed that term from pg_resetxlog.c, though. BTW, initdb and pg_ctl also
> have the same check and the error message is as follows. Isn't this better?
> Thought?
>
> ("%s: cannot be run as root\n"
> "Please log in (using, e.g., \"su\") as the "
> "(unprivileged) user that will\n"
> "own the server process.\n
I'm fine with that as well. Why not updating the message of
pg_resetxlog as well then? It would be good to be consistent.
I guess that the call to set_pglocale_pgservice() should be added as
well in the first patch (see last version upthread), this has nothing
to do with the logging issues.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Shigeru Hanada | 2015-04-07 07:42:32 | Re: Custom/Foreign-Join-APIs (Re: [v9.5] Custom Plan API) |
Previous Message | Michael Paquier | 2015-04-07 07:33:47 | Re: pg_rewind and log messages |