| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Assignment of valid collation for SET operations on queries with UNKNOWN types. |
| Date: | 2017-01-25 05:24:04 |
| Message-ID: | CAB7nPqRG6CNG9RPGSkgo1mAqLibHihLryMTNfp8KYiohCKMOCQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 25, 2017 at 12:46 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I wrote:
>> Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
>>> The table of Pseudo-Types needs to be updated as well with unknown in
>>> datatype.sgml.
>
>> Check.
>
> Here's an updated patch with doc changes. Aside from that one,
> I tried to spell "pseudo-type" consistently, and I changed one
> place where we were calling something a pseudo-type that isn't.
Thanks for the updated version, all the comments have been addressed.
You have left a lot of code comments using "pseudotype" instead of
"pseudo-type" in the code. I am guessing that this is on purpose,
which is fine for me. There is no point to make back-patching more
complicated for just that.
The CF app has been updated to ready for committer for the record.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shruti Rawal | 2017-01-25 05:25:16 | Re: PostgreSQL 8.2 installation error on Windows 2016 server |
| Previous Message | Beena Emerson | 2017-01-25 05:13:40 | Re: Proposal : For Auto-Prewarm. |